Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/61048 )
Change subject: {drivers,northbridge,security}: Remove unused <cpu/x86/lapic.h> ......................................................................
{drivers,northbridge,security}: Remove unused <cpu/x86/lapic.h>
Found using: diff <(git grep -l '#include <cpu/x86/lapic.h>' -- src/) <(git grep -l 'xapic_read|xapic_write|xapic_send_ipi|xapic_busy|x2apic_read|x2apic_write|x2apic_send_ipi|is_x2apic_mode|lapic_read|lapic_write|lapic_update32|lapic_send_ipi|lapic_busy|initial_lapicid|lapicid|stop_this_cpu|enable_lapic|disable_lapic|setup_lapic' -- src/) |grep ">"
Change-Id: Ie8fcf61a0604281c23cd3f589f1aa0cdbbd9366b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/61048 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin L Roth martinroth@google.com --- M src/drivers/generic/ioapic/ioapic.c M src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c M src/northbridge/amd/pi/00730F01/northbridge.c M src/security/intel/txt/common.c M src/security/intel/txt/getsec.c 5 files changed, 0 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Martin L Roth: Looks good to me, approved
diff --git a/src/drivers/generic/ioapic/ioapic.c b/src/drivers/generic/ioapic/ioapic.c index 0097c59..8184484 100644 --- a/src/drivers/generic/ioapic/ioapic.c +++ b/src/drivers/generic/ioapic/ioapic.c @@ -3,7 +3,6 @@ #include <device/device.h> #include "chip.h" #include <arch/ioapic.h> -#include <cpu/x86/lapic.h>
static void ioapic_init(struct device *dev) { diff --git a/src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c b/src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c index 9aef1b6..53d9182 100644 --- a/src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c +++ b/src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c @@ -3,7 +3,6 @@ #include <console/console.h> #include <cpu/cpu.h> #include <cpu/x86/mp.h> -#include <cpu/x86/lapic.h> #include <cpu/intel/microcode.h> #include <fsp/api.h> #include <fsp/ppi/mp_service_ppi.h> diff --git a/src/northbridge/amd/pi/00730F01/northbridge.c b/src/northbridge/amd/pi/00730F01/northbridge.c index 69dcc62..8a136b6 100644 --- a/src/northbridge/amd/pi/00730F01/northbridge.c +++ b/src/northbridge/amd/pi/00730F01/northbridge.c @@ -17,7 +17,6 @@ #include <Porting.h> #include <AGESA.h> #include <Topology.h> -#include <cpu/x86/lapic.h> #include <cpu/amd/msr.h> #include <cpu/amd/mtrr.h> #include <acpi/acpigen.h> diff --git a/src/security/intel/txt/common.c b/src/security/intel/txt/common.c index 14bd296..ea348d2 100644 --- a/src/security/intel/txt/common.c +++ b/src/security/intel/txt/common.c @@ -4,7 +4,6 @@ #include <console/console.h> #include <cbfs.h> #include <cpu/x86/cr.h> -#include <cpu/x86/lapic.h> #include <cpu/x86/mp.h> #include <cpu/x86/msr.h> #include <cpu/x86/mtrr.h> diff --git a/src/security/intel/txt/getsec.c b/src/security/intel/txt/getsec.c index 16ffedd..e2cb6cd 100644 --- a/src/security/intel/txt/getsec.c +++ b/src/security/intel/txt/getsec.c @@ -3,7 +3,6 @@ #include <cf9_reset.h> #include <console/console.h> #include <cpu/intel/common/common.h> -#include <cpu/x86/lapic.h> #include <cpu/x86/cr.h> #include <cpu/x86/cache.h> #include <cpu/x86/mp.h>