Attention is currently required from: Sean Rhodes, Paul Menzel, Angel Pons, Felix Held.
Andy Pont has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58343 )
Change subject: ec/starlabs: Add standardised ITE EC support
......................................................................
Patch Set 44:
(2 comments)
File src/ec/starlabs/merlin/ec.c:
https://review.coreboot.org/c/coreboot/+/58343/comment/b2b36b61_ce432f30
PS44, Line 14: u16 it_get_version(void)
This file seems to have developed a mismatched use of type definitions i.e we have u16 and uint8_t. Need to stick with one or the other!
https://review.coreboot.org/c/coreboot/+/58343/comment/651692ad_2c123fe4
PS44, Line 47: static u16 ite_get_chip_id(unsigned int port)
: {
: return (pnp_read_index(port, ITE_CHIPID1) << 8) |
: pnp_read_index(port, ITE_CHIPID2);
: }
:
This probably needs moving up to the top next to the it_get_version() function.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58343
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8023c26de23c874c84106fda96e64dcfa0c5ba32
Gerrit-Change-Number: 58343
Gerrit-PatchSet: 44
Gerrit-Owner: Sean Rhodes
admin@starlabs.systems
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andy Pont
andy.pont@sdcsystems.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sean Rhodes
admin@starlabs.systems
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 17 Nov 2021 10:57:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment