Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84023?usp=email )
Change subject: soc/mediatek/mt8196: add usb host support
......................................................................
Patch Set 8:
(3 comments)
File src/soc/mediatek/mt8196/usb.c:
https://review.coreboot.org/c/coreboot/+/84023/comment/64c98d7b_16014dcb?usp... :
PS7, Line 10: #include <gpio.h>
: #include <soc/pll_common.h>
Do we need these?
Done
https://review.coreboot.org/c/coreboot/+/84023/comment/d0486fb2_30955934?usp... :
PS7, Line 18: set
sets
Done
https://review.coreboot.org/c/coreboot/+/84023/comment/dda39ebe_d296dd2b?usp... :
PS7, Line 18: force
change
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84023?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia4efcddac9bf5e04e688648a5c22384075a0b026
Gerrit-Change-Number: 84023
Gerrit-PatchSet: 8
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Mingjin Ge
mingjin.ge@mediatek.corp-partner.google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Tue, 27 Aug 2024 11:58:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com