Attention is currently required from: Ravi kumar, Paul Menzel, mturney mturney. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55865 )
Change subject: selfboot: Add support for selfload in romstage ......................................................................
Patch Set 5:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55865/comment/9a354ee5_c37f3322 PS4, Line 7: selfboot: Add
Please use exactly one space after the colon.
Done
https://review.coreboot.org/c/coreboot/+/55865/comment/43ef597e_ca82fba9 PS4, Line 11:
Please paste one example linker error.
This is the error. I don't think that this needs to be in the commit message:
LINK cbfs/fallback/romstage.debug /opt/coreboot-sdk/bin/aarch64-elf-ld.bfd: /build/herobrine/tmp/portage/sys-boot/coreboot-9999/work/build/herobrine/romstage/lib/selfboot.o: in function `segment_targets_type': /build/herobrine/tmp/portage/sys-boot/coreboot-9999/work/coreboot-9999/src/lib/selfboot.c:38: undefined reference to `bootmem_region_targets_type' /build/herobrine/tmp/portage/sys-boot/coreboot-9999/work/coreboot-9999/src/lib/selfboot.c:38:(.text.selfload_mapped+0x78): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `bootmem_region_targets_type' /opt/coreboot-sdk/bin/aarch64-elf-ld.bfd: /build/herobrine/tmp/portage/sys-boot/coreboot-9999/work/coreboot-9999/src/lib/selfboot.c:45: undefined reference to `bootmem_dump_ranges' /build/herobrine/tmp/portage/sys-boot/coreboot-9999/work/coreboot-9999/src/lib/selfboot.c:45:(.text.selfload_mapped+0xa8): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `bootmem_dump_ranges' make: *** [src/arch/arm64/Makefile.inc:99: /build/herobrine/tmp/portage/sys-boot/coreboot-9999/work/build/herobrine/cbfs/fallback/romstage.debug] Error 1
https://review.coreboot.org/c/coreboot/+/55865/comment/d24d54c0_a8670e5a PS4, Line 12: BUG=None
Don’t all Chromium related things need a bug entry?
Not necessarily. Sometimes cleanup issues or simple compilation fixes can be done w/o creating a bug.
https://review.coreboot.org/c/coreboot/+/55865/comment/2044f5fe_a2d0f2dc PS4, Line 15: can compile : successfully.
successful compilation
Done