Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Furquan Shaikh, Marshall Dawson, Karthik Ramasubramanian.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56884 )
Change subject: soc/amd/common/block/spi: Add SPI config to Kconfig
......................................................................
Patch Set 3:
(2 comments)
File src/soc/amd/common/block/spi/Kconfig:
https://review.coreboot.org/c/coreboot/+/56884/comment/2caacaa4_b5abea06
PS3, Line 20: 0
HOLD line alone needs to be floating. Otherwise I believe it should support Dual mode.
i'd use some of the normal single bit spi modes here, since that's what will work in all cases. the boards can select a wider interface if the flash chip can support that on those
https://review.coreboot.org/c/coreboot/+/56884/comment/77f37eb0_b3eb27da
PS3, Line 40: 0
i'd use 3 as default for this and the other speeds as well, since 16 MHz will be working in all configurations and if a mainboard can support faster speeds, it can override the Kconfig option. 66MHz won't work on all possible mainboards and i'd like to have working defaults in the chipset's Kconfig
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56884
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8f29e49e886bd99b39172905e21bfd392c6c10e2
Gerrit-Change-Number: 56884
Gerrit-PatchSet: 3
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 20 Aug 2021 19:59:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment