Change in coreboot[master]: mb/google/mancomb: Remove lid swtich - coreboot-gerrit

29 Apr 2021


      Attention is currently required from: Raul Rangel, Furquan Shaikh, Karthik Ramasubramanian.
Ivy Jian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52602 )
Change subject: mb/google/mancomb: Remove lid swtich
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52602/comment/02503ef9_bf4a7dd6 
PS1, Line 13: TEST=Depthcharge no longer halts complaining that coreboot didn't sample
            : the pin
...
Need to remove it from here too: https://source.chromium. […]
Thanks Raul and Karthik. It is working. I updated the patch and uploaded a depthcharge CL.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/52602
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd0fcec9557bf7ebad64ce9342d3b50eb511522b
Gerrit-Change-Number: 52602
Gerrit-PatchSet: 2
Gerrit-Owner: Ivy Jian ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Mathew King mathewk@chromium.org
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Thu, 29 Apr 2021 03:39:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel rrangel@chromium.org
Comment-In-Reply-To: Ivy Jian ivy_jian@compal.corp-partner.google.com
Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com
Gerrit-MessageType: comment