Attention is currently required from: Felix Held.
Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79011?usp=email )
Change subject: ec/dell/mec5035: Hook up radio enables to option API
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
not 100% sure how that api behaves when there's a cmos option table that doesn't have those options, […]
Skimming the `drivers/pc80/rtc` code, it looks like `get_uint_option` returns the default value if `cmos_get_uint_option` can't find an entry in the option table.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79011?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibfa17ca83ca178c942d9c41533152235384e0cdf
Gerrit-Change-Number: 79011
Gerrit-PatchSet: 4
Gerrit-Owner: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 22 Jan 2024 18:16:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment