Attention is currently required from: Jakub Czapiga, Kapil Porwal, Paul Menzel, Subrata Banik, Tarun Tuli.
Sukumar Ghorai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76826?usp=email )
Change subject: soc/intel/meteorlake: Allow mainboard to configure c1-state auto-demotion
......................................................................
Patch Set 4:
(2 comments)
File src/soc/intel/meteorlake/chip.h:
https://review.coreboot.org/c/coreboot/+/76826/comment/672b61f5_a51514fc :
PS3, Line 372: * Enable or Disable C1 C-state Auto Demotion.
Maybe add, what that does?
Acknowledged!
We have some details why we disable this feature for chorme only.
https://review.coreboot.org/c/coreboot/+/76826/comment/041a34db_b2cdf7bd :
PS3, Line 373: C-state
C1 C-state
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76826?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2cc60bd297271fcb3000c0298af71208e3be60fc
Gerrit-Change-Number: 76826
Gerrit-PatchSet: 4
Gerrit-Owner: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Wed, 02 Aug 2023 06:47:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment