Attention is currently required from: Angel Pons.
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/81907?usp=email )
Change subject: util/lint: Add lint rule to avoid duplicated includes
......................................................................
Patch Set 13:
(1 comment)
File util/lint/lint-stable-031-duplicated-includes:
https://review.coreboot.org/c/coreboot/+/81907/comment/eec91fd0_3f1b8111?usp... :
PS13, Line 48: check_duplicates '<commonlib/bsd/cb_err.h>|<limits.h>|<stdbool.h>|<stdint.h>|<stddef.h>' '<types.h>'
This is enforcing code style. And not everything can use `types.h` (e.g. utils).
no. This will check if <types.h> included and if at the same time one of '<commonlib/bsd/cb_err.h>|<limits.h>|<stdbool.h>|<stdint.h>|<stddef.h>' is also included.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81907?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia14c73f0bffa6ee4b73254d71836f793af8771c4
Gerrit-Change-Number: 81907
Gerrit-PatchSet: 13
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 30 Jul 2024 04:26:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com