Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56797 )
Change subject: soc/mediatek/mt8192: initialize DFD
......................................................................
Patch Set 4:
(2 comments)
File src/soc/mediatek/mt8192/Kconfig:
https://review.coreboot.org/c/coreboot/+/56797/comment/a008f83c_4e352f63
PS4, Line 70: This option enables DFD (Design for Debug) settings.
maybe add some description like commit message in future version .
Done
File src/soc/mediatek/mt8192/dfd.c:
https://review.coreboot.org/c/coreboot/+/56797/comment/3a988e8b_7419851d
PS4, Line 9: printk(BIOS_INFO, "[%s]\n", __func__);
maybe add more message like "dfd initialize" in future version.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56797
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I39a4391c1d1e832d77b709f8f899bb1c6dcacd69
Gerrit-Change-Number: 56797
Gerrit-PatchSet: 4
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Thu, 12 Aug 2021 05:10:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment