[L] Change in coreboot[main]: mb/hardkernel/odroid-h4: Add support for ODROID-H4 series

[Angel Pons (Code Review)]

Attention is currently required from: Alicja Michalska, David Milosevic, Felix Held, Felix Singer, Lean Sheng Tan.

Angel Pons has posted comments on this change by David Milosevic. ( https://review.coreboot.org/c/coreboot/+/83979?usp=email )

Change subject: mb/hardkernel/odroid-h4: Add support for ODROID-H4 series
......................................................................

Patch Set 9:

(8 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/83979/comment/6aedecb7_42e228a3?usp... :
PS7, Line 9: Adds
> Add

Done

https://review.coreboot.org/c/coreboot/+/83979/comment/424295b4_1b1ad44d?usp... :
PS7, Line 10: 2
> The board has 4 USB ports on the back, and there's more USB ports on one of the headers

Done

File src/mainboard/hardkernel/odroid-h4/Kconfig:

https://review.coreboot.org/c/coreboot/+/83979/comment/8b9ad5dc_403d1b84?usp... :
PS7, Line 28: 	string
> Type not needed

Done

File src/mainboard/hardkernel/odroid-h4/bootblock.c:

https://review.coreboot.org/c/coreboot/+/83979/comment/f47975c5_da556188?usp... :
PS7, Line 13: ite_reg_write(GPIO_DEV, 0x29, 0x01); // The value matches vendor firmware
            : 	ite_reg_write(GPIO_DEV, 0x2c, 0x41); // Internal Voltage Divider for ACC3
            : 	ite_reg_write(GPIO_DEV, 0xbc, 0xc0); // GP56, GP57 Internal pullup
            : 	ite_reg_write(GPIO_DEV, 0xbd, 0x03); // GP60, GP61 Internal pullup
            : 	ite_reg_write(GPIO_DEV, 0xc3, 0x41); // GP40, GP46 Simple I/O function
> Are the comments accurate? I don't have a datasheet for this Super I/O

Gone

File src/mainboard/hardkernel/odroid-h4/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/83979/comment/61079cb1_c9847ccb?usp... :
PS7, Line 5: 	register "pmc_gpe0_dw0" = "GPP_B"
           : 	register "pmc_gpe0_dw1" = "GPP_D"
           : 	register "pmc_gpe0_dw2" = "GPP_E"
> do those match what the vendor firmware does? CB:84213 has other values for that and at least the de […]

Adjusted accordingly, I have no idea where the original values came from. But I think none of the GPIOs are used for GPEs anyway.

https://review.coreboot.org/c/coreboot/+/83979/comment/49ac67e8_fa44844a?usp... :
PS7, Line 36: 		device ref tcss_xhci on
> tcss xhci is unused; the pch xhci controller which is the one used is missing in the devicetree. […]

Done

File src/mainboard/hardkernel/odroid-h4/gpio.h:

PS7:
> i wonder if this is missing the vgpios; at least the other patch for adding the mainboard support ha […]

I'm not even sure what the VGPIOs do, nor why they would need to be configured. Board works fine as-is

File src/mainboard/hardkernel/odroid-h4/romstage_fsp_params.c:

https://review.coreboot.org/c/coreboot/+/83979/comment/3dce2b1e_6e6dcad3?usp... :
PS7, Line 19: 0x52
> This is weird, but if it works (memory is detected and all capacity is found) then it's correct. […]

Done, works fine