Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48180 )
Change subject: soc/amd/picasso/aoac: make aoac_devs array unsigned ......................................................................
soc/amd/picasso/aoac: make aoac_devs array unsigned
The numbers in the array are unsigned, so use an unsigned type there.
Change-Id: I9a85594de0e4c53db965ab84239f19eb46432348 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/amd/picasso/aoac.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/48180/1
diff --git a/src/soc/amd/picasso/aoac.c b/src/soc/amd/picasso/aoac.c index f9fe0e2..00f26fe 100644 --- a/src/soc/amd/picasso/aoac.c +++ b/src/soc/amd/picasso/aoac.c @@ -21,7 +21,7 @@ * waiting for each device to become available, a single delay will be * executed. The console UART is handled separately from this table. */ -const static int aoac_devs[] = { +const static unsigned int aoac_devs[] = { FCH_AOAC_DEV_AMBA, FCH_AOAC_DEV_I2C2, FCH_AOAC_DEV_I2C3,
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48180 )
Change subject: soc/amd/picasso/aoac: make aoac_devs array unsigned ......................................................................
Patch Set 1: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48180 )
Change subject: soc/amd/picasso/aoac: make aoac_devs array unsigned ......................................................................
soc/amd/picasso/aoac: make aoac_devs array unsigned
The numbers in the array are unsigned, so use an unsigned type there.
Change-Id: I9a85594de0e4c53db965ab84239f19eb46432348 Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/48180 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/soc/amd/picasso/aoac.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Marshall Dawson: Looks good to me, approved
diff --git a/src/soc/amd/picasso/aoac.c b/src/soc/amd/picasso/aoac.c index f9fe0e2..00f26fe 100644 --- a/src/soc/amd/picasso/aoac.c +++ b/src/soc/amd/picasso/aoac.c @@ -21,7 +21,7 @@ * waiting for each device to become available, a single delay will be * executed. The console UART is handled separately from this table. */ -const static int aoac_devs[] = { +const static unsigned int aoac_devs[] = { FCH_AOAC_DEV_AMBA, FCH_AOAC_DEV_I2C2, FCH_AOAC_DEV_I2C3,
-
Felix Held (Code Review) -
Marshall Dawson (Code Review)