Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42685 )
Change subject: soc/amd/common: Drop ACPIMMIO bank for SMBus device PCI config ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42685/6/src/soc/amd/picasso/uart.c File src/soc/amd/picasso/uart.c:
https://review.coreboot.org/c/coreboot/+/42685/6/src/soc/amd/picasso/uart.c@... PS6, Line 60: Help
If psp verstage is the first code we can execute, we will want to be able to configure the UART and […]
D14F0 seems to only be for 1.8MHz and configuring legacy UART IO.
It's also confusing that we have PICASSO_UART_48MZ. https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/th...
As for the PSP, all console writes are done using system calls, so the PSP owns the console UART.