Attention is currently required from: Anil Kumar K, Krishna P Bhat D, Rizwan Qureshi.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74874?usp=email )
Change subject: soc/intel/cse: Check PSR bit before issuing PSR backup command
......................................................................
Patch Set 6:
(3 comments)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/74874/comment/e70b9427_9f0d07ea :
PS6, Line 1077: printk(BIOS_INFO, "Check if PSR is supported in this SKU !\n");
same
https://review.coreboot.org/c/coreboot/+/74874/comment/f033dbb3_98a3a504 :
PS6, Line 1090: printk(BIOS_DEBUG, "PSR is supported in this SKU !\n");
we don't need such prints
https://review.coreboot.org/c/coreboot/+/74874/comment/28a52c74_94b16251 :
PS6, Line 1106:
shouldn't we check this at line #1100 ?
what is the boot time impact ? care to add a timestamp ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74874?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6e92341a9dc799146eb8f1a70b3a4a16fd1aa0ae
Gerrit-Change-Number: 74874
Gerrit-PatchSet: 6
Gerrit-Owner: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Comment-Date: Thu, 28 Sep 2023 09:43:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment