Attention is currently required from: Tarun Tuli, Martin L Roth, Subrata Banik, Matt DeVillier, John Zhao, Kapil Porwal, Tim Wawrzynczak.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64561 )
Change subject: soc/intel/alderlake/acpi: Add Kconfig options for SCM and FCM
......................................................................
Patch Set 9:
(2 comments)
File src/soc/intel/alderlake/acpi/tcss.asl:
https://review.coreboot.org/c/coreboot/+/64561/comment/f65cd208_e83f801a
PS7, Line 164: #if CONFIG(CHROMEOS)
Like PS8? […]
Done
File src/soc/intel/meteorlake/acpi/tcss.asl:
https://review.coreboot.org/c/coreboot/+/64561/comment/d8b3a6ee_50d0c063
PS9, Line 158: #if CONFIG(SOFTWARE_CONNECTION_MANAGER)
unlike ADL/TGL, SCM is always disabled for MTL. Is this expected? […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64561
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iac31d37c0873f41f7b14e1051fe214466d1ebdd8
Gerrit-Change-Number: 64561
Gerrit-PatchSet: 9
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: John Zhao
john.zhao@intel.corp-partner.google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Comment-Date: Thu, 05 Jan 2023 17:39:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes
sean@starlabs.systems
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Kapil Porwal
kapilporwal@google.com
Gerrit-MessageType: comment