Attention is currently required from: Bao Zheng, Jason Nien, Al Hirani.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62911 )
Change subject: amdfwtool: Allow for the tool to support additional PSP entries
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62911/comment/d4793776_3dd899b2
PS2, Line 8:
What PSP entries are not supported right now? Please start with a description of the problem.
https://review.coreboot.org/c/coreboot/+/62911/comment/1e5db0e0_c65ede38
PS2, Line 9: Consolidate the MAX_BIOS_ENTRIES and MAX_PSP_ENTRIES definitions into one file
Please wrap lines after 72 characters, and add a dot/period to the end of sentences.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62911
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3c64a1875010e7fb368967283df6baf1cc7ba8d
Gerrit-Change-Number: 62911
Gerrit-PatchSet: 2
Gerrit-Owner: Al Hirani
al.hirani13@gmail.com
Gerrit-Reviewer: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ritul guru
ritul.bits@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Al Hirani
al.hirani13@gmail.com
Gerrit-Comment-Date: Thu, 14 Apr 2022 20:26:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment