Change in coreboot[master]: mb/google/dedede/var/drawcia: support elan touchpad

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Chen Wisley (Code Review)

30 Jun 2020 30 Jun '20

3:06 p.m.

Chen Wisley has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42922 )

Change subject: mb/google/dedede/var/drawcia: support elan touchpad ......................................................................

mb/google/dedede/var/drawcia: support elan touchpad

BUG=155002811 TEST=build drawcia, and check touchpad can work.

Change-Id: I674236aa6937a0444a85e6b8e2fb9a7925b56f5c --- M src/mainboard/google/dedede/variants/drawcia/overridetree.cb 1 file changed, 8 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/42922/1

diff --git a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb index ee1abc9..a92dbdb 100644 --- a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb +++ b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb @@ -38,15 +38,14 @@

device domain 0 on device pci 15.0 on - chip drivers/i2c/hid - register "generic.hid" = ""PNP0C50"" - register "generic.desc" = ""Synaptics Touchpad"" - register "generic.irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPP_B3_IRQ)" - register "generic.wake" = "GPE0_DW0_03" - register "generic.probed" = "1" - register "hid_desc_reg_offset" = "0x20" - device i2c 0x2c on end + chip drivers/i2c/generic + register "hid" = ""ELAN0000"" + register "desc" = ""ELAN Touchpad"" + register "irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPP_B3_IRQ)" + register "wake" = "GPE0_DW0_03" + register "probed" = "1" + device i2c 15 on end end - end + end #I2C 0 end end

Attachments:

attachment.htm (text/html — 4.0 KB)

Show replies by date

Chen Wisley (Code Review)

30 Jun 30 Jun

3:11 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42922

to look at the new patch set (#2).

Change subject: mb/google/dedede/var/drawcia: support elan touchpad ......................................................................

mb/google/dedede/var/drawcia: support elan touchpad

BUG=155002811 TEST=build drawcia, and check touchpad can work.

Change-Id: I674236aa6937a0444a85e6b8e2fb9a7925b56f5c Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/dedede/variants/drawcia/overridetree.cb 1 file changed, 8 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/42922/2

Chen Wisley (Code Review)

2 Jul 2 Jul

5:20 a.m.

Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42922 )

Change subject: mb/google/dedede/var/drawcia: support elan touchpad ......................................................................

Patch Set 2:

Hi Karthik,

Could you help to review?

Thanks

-- To view, visit https://review.coreboot.org/c/coreboot/+/42922 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I674236aa6937a0444a85e6b8e2fb9a7925b56f5c Gerrit-Change-Number: 42922 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Henry Sun henrysun@google.com Gerrit-CC: Karthik Ramasubramanian kramasub@google.com Gerrit-CC: Marco Chen marcochen@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 02 Jul 2020 03:20:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

6 Jul 6 Jul

3:26 p.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42922 )

Change subject: mb/google/dedede/var/drawcia: support elan touchpad ......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/42922/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/42922/2//COMMIT_MSG@7 PS2, Line 7: support Nit: Support Elan touchpad

https://review.coreboot.org/c/coreboot/+/42922/2//COMMIT_MSG@9 PS2, Line 9: 155002811 b:155002811

-- To view, visit https://review.coreboot.org/c/coreboot/+/42922 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I674236aa6937a0444a85e6b8e2fb9a7925b56f5c Gerrit-Change-Number: 42922 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Henry Sun henrysun@google.com Gerrit-CC: Karthik Ramasubramanian kramasub@google.com Gerrit-CC: Marco Chen marcochen@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 06 Jul 2020 13:26:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Chen Wisley (Code Review)

7 Jul 7 Jul

2:57 a.m.

New subject: Change in coreboot[master]: mb/google/dedede/var/drawcia: Support elan touchpad

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42922

to look at the new patch set (#3).

Change subject: mb/google/dedede/var/drawcia: Support elan touchpad ......................................................................

mb/google/dedede/var/drawcia: Support elan touchpad

BUG=b:155002811 TEST=build drawcia, and check touchpad can work.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/42922/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/42922 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I674236aa6937a0444a85e6b8e2fb9a7925b56f5c Gerrit-Change-Number: 42922 Gerrit-PatchSet: 3 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Henry Sun henrysun@google.com Gerrit-CC: Karthik Ramasubramanian kramasub@google.com Gerrit-CC: Marco Chen marcochen@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Chen Wisley (Code Review)

2:58 a.m.

New subject: Change in coreboot[master]: mb/google/dedede/var/drawcia: Support Elan touchpad

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42922

to look at the new patch set (#4).

Change subject: mb/google/dedede/var/drawcia: Support Elan touchpad ......................................................................

mb/google/dedede/var/drawcia: Support Elan touchpad

BUG=b:155002811 TEST=build drawcia, and check touchpad can work.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/42922/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/42922 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I674236aa6937a0444a85e6b8e2fb9a7925b56f5c Gerrit-Change-Number: 42922 Gerrit-PatchSet: 4 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Henry Sun henrysun@google.com Gerrit-CC: Karthik Ramasubramanian kramasub@google.com Gerrit-CC: Marco Chen marcochen@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Chen Wisley (Code Review)

2:59 a.m.

New subject: Change in coreboot[master]: mb/google/dedede/var/drawcia: Support Elan touchpad

Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42922 )

Change subject: mb/google/dedede/var/drawcia: Support Elan touchpad ......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/42922/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/42922/2//COMMIT_MSG@7 PS2, Line 7: support

...

Nit: Support Elan touchpad

Done

https://review.coreboot.org/c/coreboot/+/42922/2//COMMIT_MSG@9 PS2, Line 9: 155002811

...

b:155002811

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/42922 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I674236aa6937a0444a85e6b8e2fb9a7925b56f5c Gerrit-Change-Number: 42922 Gerrit-PatchSet: 4 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Henry Sun henrysun@google.com Gerrit-CC: Karthik Ramasubramanian kramasub@google.com Gerrit-CC: Marco Chen marcochen@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 07 Jul 2020 00:59:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

4:39 a.m.

New subject: Change in coreboot[master]: mb/google/dedede/var/drawcia: Support Elan touchpad

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42922 )

Change subject: mb/google/dedede/var/drawcia: Support Elan touchpad ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/42922 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I674236aa6937a0444a85e6b8e2fb9a7925b56f5c Gerrit-Change-Number: 42922 Gerrit-PatchSet: 4 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Henry Sun henrysun@google.com Gerrit-CC: Marco Chen marcochen@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 07 Jul 2020 02:39:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

8 Jul 8 Jul

5:49 a.m.

New subject: Change in coreboot[master]: mb/google/dedede/var/drawcia: Support Elan touchpad

Karthik Ramasubramanian has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42922 )

Change subject: mb/google/dedede/var/drawcia: Support Elan touchpad ......................................................................

mb/google/dedede/var/drawcia: Support Elan touchpad

BUG=b:155002811 TEST=build drawcia, and check touchpad can work.

Change-Id: I674236aa6937a0444a85e6b8e2fb9a7925b56f5c Signed-off-by: Wisley Chen wisley.chen@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42922 Reviewed-by: Karthik Ramasubramanian kramasub@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/dedede/variants/drawcia/overridetree.cb 1 file changed, 8 insertions(+), 9 deletions(-)

Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/coreboot/+/42922 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I674236aa6937a0444a85e6b8e2fb9a7925b56f5c Gerrit-Change-Number: 42922 Gerrit-PatchSet: 5 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Henry Sun henrysun@google.com Gerrit-CC: Marco Chen marcochen@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1400

days inactive

1408

days old

coreboot-gerrit@coreboot.org

8 comments

2 participants

tags (0)

participants (2)

Chen Wisley (Code Review)
Karthik Ramasubramanian (Code Review)