Nicholas Chin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83358?usp=email )
Change subject: autoport: Drop ioapic devicetree entry generation ......................................................................
autoport: Drop ioapic devicetree entry generation
The ioapic and ioapic_irq keywords are no longer valid as of commit e84b095d3a23 (util/sconfig: Remove unused ioapic and irq keywords), and the associated driver had previously been removed in commit ca5a793ec31c (drivers/generic/ioapic: Drop poor implementation), so drop it from autoport. The IOAPICIRQs map that this code relied on to generate entries never seems to have been populated anyway in any commit so this has always essentially been dead code.
Change-Id: Icf2582594b244cf5f726c722eb3a3c12573a2662 Signed-off-by: Nicholas Chin nic.c3.14@gmail.com --- M util/autoport/main.go 1 file changed, 1 insertion(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/83358/1
diff --git a/util/autoport/main.go b/util/autoport/main.go index 18fb694..a8845b0 100644 --- a/util/autoport/main.go +++ b/util/autoport/main.go @@ -96,12 +96,6 @@ SaneVendor string }
-type IOAPICIRQ struct { - APICID int - IRQNO [4]int -} - -var IOAPICIRQs map[PCIAddr]IOAPICIRQ = map[PCIAddr]IOAPICIRQ{} var KconfigBool map[string]bool = map[string]bool{} var KconfigComment map[string]string = map[string]string{} var KconfigString map[string]string = map[string]string{} @@ -366,7 +360,7 @@ func WriteDev(dt *os.File, offset int, alias string, dev DevTreeNode) { Offset(dt, offset) switch dev.Chip { - case "cpu_cluster", "lapic", "domain", "ioapic": + case "cpu_cluster", "lapic", "domain": fmt.Fprintf(dt, "device %s 0x%x ", dev.Chip, dev.Dev) writeOn(dt, dev) case "pci", "pnp": @@ -391,16 +385,6 @@ fmt.Fprintf(dt, "subsystemid 0x%04x 0x%04x\n", dev.SubVendor, dev.SubSystem) }
- ioapic, ok := IOAPICIRQs[PCIAddr{Bus: dev.Bus, Dev: dev.Dev, Func: dev.Func}] - if dev.Chip == "pci" && ok { - for pin, irq := range ioapic.IRQNO { - if irq != 0 { - Offset(dt, offset+1) - fmt.Fprintf(dt, "ioapic_irq %d INT%c 0x%x\n", ioapic.APICID, 'A'+pin, irq) - } - } - } - keys := []string{} for reg, _ := range dev.Registers { keys = append(keys, reg)