Change in coreboot[master]: soc/intel/apollolake: Don't select repo option for Gemini Lake
Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40124 )
Change subject: soc/intel/apollolake: Don't select repo option for Gemini Lake ......................................................................
soc/intel/apollolake: Don't select repo option for Gemini Lake
Change-Id: I70fbc0c2959acba71cbb3b2c7b6c0d6d743c91e5 Signed-off-by: Nico Huber nico.h@gmx.de --- M src/soc/intel/apollolake/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/40124/1
diff --git a/src/soc/intel/apollolake/Kconfig b/src/soc/intel/apollolake/Kconfig index ed35eaa..e5ab28c 100644 --- a/src/soc/intel/apollolake/Kconfig +++ b/src/soc/intel/apollolake/Kconfig @@ -44,7 +44,7 @@ select GENERIC_GPIO_LIB select INTEL_DESCRIPTOR_MODE_CAPABLE select HAVE_SMI_HANDLER - select HAVE_INTEL_FSP_REPO + select HAVE_INTEL_FSP_REPO if !SOC_INTEL_GLK select MRC_SETTINGS_PROTECT select MRC_SETTINGS_VARIABLE_DATA select NO_XIP_EARLY_STAGES
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40124 )
Change subject: soc/intel/apollolake: Don't select repo option for Gemini Lake ......................................................................
Patch Set 1: Code-Review+2
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40124 )
Change subject: soc/intel/apollolake: Don't select repo option for Gemini Lake ......................................................................
Patch Set 1: Code-Review+2
Mimoja has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40124 )
Change subject: soc/intel/apollolake: Don't select repo option for Gemini Lake ......................................................................
Patch Set 2: Code-Review+1
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40124 )
Change subject: soc/intel/apollolake: Don't select repo option for Gemini Lake ......................................................................
Patch Set 2: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40124 )
Change subject: soc/intel/apollolake: Don't select repo option for Gemini Lake ......................................................................
soc/intel/apollolake: Don't select repo option for Gemini Lake
Change-Id: I70fbc0c2959acba71cbb3b2c7b6c0d6d743c91e5 Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/40124 Reviewed-by: Mimoja coreboot@mimoja.de Reviewed-by: Felix Singer felixsinger@posteo.net Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Matt DeVillier matt.devillier@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/apollolake/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved Felix Singer: Looks good to me, approved Mimoja: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/src/soc/intel/apollolake/Kconfig b/src/soc/intel/apollolake/Kconfig index ed35eaa..e5ab28c 100644 --- a/src/soc/intel/apollolake/Kconfig +++ b/src/soc/intel/apollolake/Kconfig @@ -44,7 +44,7 @@ select GENERIC_GPIO_LIB select INTEL_DESCRIPTOR_MODE_CAPABLE select HAVE_SMI_HANDLER - select HAVE_INTEL_FSP_REPO + select HAVE_INTEL_FSP_REPO if !SOC_INTEL_GLK select MRC_SETTINGS_PROTECT select MRC_SETTINGS_VARIABLE_DATA select NO_XIP_EARLY_STAGES
-
Angel Pons (Code Review) -
Felix Singer (Code Review)
-
Matt DeVillier (Code Review)
-
Mimoja (Code Review)
-
Nico Huber (Code Review)