Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43922 )
Change subject: mb/intel/cedarisland: Update UDP option offsets for FSP-M ......................................................................
Patch Set 3: Code-Review-1
(3 comments)
I don't think we need this patch, we can do away with the follow-ups.
https://review.coreboot.org/c/coreboot/+/43922/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43922/3//COMMIT_MSG@7 PS3, Line 7: UDP Oh no, FSP connects to the internet? https://en.wikipedia.org/wiki/User_Datagram_Protocol
https://review.coreboot.org/c/coreboot/+/43922/3/src/mainboard/intel/cedaris... File src/mainboard/intel/cedarisland_crb/romstage.c:
https://review.coreboot.org/c/coreboot/+/43922/3/src/mainboard/intel/cedaris... PS3, Line 9: void *start = (void *) m_cfg;
Yes I know. […]
This works because GNU C considers void pointer arithmetic to be the same as char pointer arithmetic. Interesting links:
https://stackoverflow.com/questions/3523145/pointer-arithmetic-for-void-poin...
https://www.quora.com/Why-is-pointer-arithmetic-with-%E2%80%9Cvoid*%E2%80%9D...
https://review.coreboot.org/c/coreboot/+/43922/3/src/mainboard/intel/cedaris... PS3, Line 10: : // BoardId (offset 0x00B9) : write8(start + 185, 0x1d); : : // BoardTypeBitmask (offset 0x00A0) : write32(start + 160, 0x11111111); : : // DebugPrintLevel (offset 0x006D) : write8(start + 109, 8); : : // KtiLinkSpeedMode (offset 0x0080) : write8(start + 128, 0); : : // KtiPrefetchEn (offset 0x0075) : write8(start + 117, 2);
See next patch - CB:43923 […]
Why do we need this patch, though?
-
Angel Pons (Code Review)