Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36356 )
Change subject: soc/intel/cannonlake: set LT_LOCK_MEMORY at end of POST
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36356/2/src/soc/intel/cannonlake/fi...
File src/soc/intel/cannonlake/finalize.c:
https://review.coreboot.org/c/coreboot/+/36356/2/src/soc/intel/cannonlake/fi...
PS2, Line 116: mp_run_on_all_cpus
given the scope of LT_LOCK_MEMORY (package), this seems unnecessary
There is no official/public documentation on this. Multiple leaks set it per-thread, FSP sets it once per package. Experiments at time of writing the patches showed, that setting it per package does not lock TSEGMB and PAVPC properly but only settig it per-thread does.
I'd be more than happy to find out what the reason for this behaviour is, but atm this seems to be a valid workaround, that doesn't hurt much.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36356
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaadd4996653c4f27d268b1c4773c1e2e86114912
Gerrit-Change-Number: 36356
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nate DeSimone
nathaniel.l.desimone@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Varun Joshi
varun.joshi@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 04 Aug 2020 01:33:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment