Hello Felix Singer, build bot (Jenkins), Patrick Georgi, Furquan Shaikh, Tim Chen, Maulik V Vaghela, Matt DeVillier, Duncan Laurie, Ren Kuo, Subrata Banik, Aamir Bohra, Patrick Rudolph, Seunghwan Kim, Nico Huber, Martin Roth, Tony Huang, Tim Wawrzynczak, Karthikeyan Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48780
to look at the new patch set (#7).
Change subject: soc/intel/{icl,tgl,adl,ehl,jsl}: move UART pad config to boards ......................................................................
soc/intel/{icl,tgl,adl,ehl,jsl}: move UART pad config to boards
UART pad configuration should not be done in common code, because that may cause short circuits, when the user sets a wrong UART index. Thus, add the corresponding pads to the early UART gpio table for the boards.
Also switch to `bootblock_mainboard_early_init` to configure the pads in early bootblock before console initialization, to make the console work as early as possible. None of the boards do any other gpio configuration in bootblock, so this should not influence behaviour in a negative way (e.g. breaking overrides).
Only boards selecting INTEL_LPSS_UART_FOR_CONSOLE have been adapted.
Change-Id: I5150110dd13e9da981a0c8614ee642037e209ca4 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/google/dedede/bootblock.c M src/mainboard/google/dedede/variants/baseboard/gpio.c M src/mainboard/google/volteer/bootblock.c M src/mainboard/google/volteer/variants/baseboard/gpio.c M src/mainboard/google/volteer/variants/delbin/gpio.c M src/mainboard/google/volteer/variants/eldrid/gpio.c M src/mainboard/google/volteer/variants/elemi/gpio.c M src/mainboard/google/volteer/variants/halvor/gpio.c M src/mainboard/google/volteer/variants/lindar/gpio.c M src/mainboard/google/volteer/variants/malefor/gpio.c M src/mainboard/google/volteer/variants/terrador/gpio.c M src/mainboard/google/volteer/variants/todor/gpio.c M src/mainboard/google/volteer/variants/trondo/gpio.c M src/mainboard/google/volteer/variants/voema/gpio.c M src/mainboard/google/volteer/variants/volteer/gpio.c M src/mainboard/google/volteer/variants/volteer2/gpio.c M src/mainboard/google/volteer/variants/voxel/gpio.c M src/mainboard/intel/adlrvp/Makefile.inc M src/mainboard/intel/adlrvp/bootblock.c A src/mainboard/intel/adlrvp/variants/adlrvp_p/Makefile.inc R src/mainboard/intel/adlrvp/variants/adlrvp_p/early_gpio.c A src/mainboard/intel/adlrvp/variants/adlrvp_p_ext_ec/Makefile.inc A src/mainboard/intel/adlrvp/variants/adlrvp_p_ext_ec/early_gpio.c M src/mainboard/intel/icelake_rvp/bootblock.c M src/mainboard/intel/icelake_rvp/variants/icl_u/gpio.c M src/mainboard/intel/icelake_rvp/variants/icl_y/gpio.c M src/mainboard/intel/jasperlake_rvp/bootblock.c M src/mainboard/intel/jasperlake_rvp/variants/jslrvp/gpio.c M src/mainboard/intel/tglrvp/bootblock.c M src/mainboard/intel/tglrvp/variants/tglrvp_up3/gpio.c M src/mainboard/intel/tglrvp/variants/tglrvp_up4/gpio.c 31 files changed, 128 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/48780/7