[M] Change in coreboot[main]: chromeec: supporting reading long battery strings - coreboot-gerrit

2 Jul 2024


      Attention is currently required from: Forest Mittelberg, Paul Menzel, Subrata Banik.
Peter Marheine has posted comments on this change by Peter Marheine. ( https://review.coreboot.org/c/coreboot/+/82775?usp=email )
Change subject: chromeec: supporting reading long battery strings
......................................................................
Patch Set 3:
(1 comment)
File src/ec/google/chromeec/acpi/battery.asl:
https://review.coreboot.org/c/coreboot/+/82775/comment/e8e66d3f_4220a71d?usp... :
PS2, Line 61: string index
...
nit: if you could highlight in the comment section the meaning of index 1-3
Added some additional information, including the symbolic names used in the EC.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/82775?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia29cacb7d86402490f9ac458f0be50e3f2192b04
Gerrit-Change-Number: 82775
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Marheine pmarheine@chromium.org
Gerrit-Reviewer: Caveh Jalali caveh@chromium.org
Gerrit-Reviewer: Forest Mittelberg bmbm@google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Forest Mittelberg bmbm@google.com
Gerrit-Comment-Date: Tue, 02 Jul 2024 06:44:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik subratabanik@google.com