Attention is currently required from: Julius Werner, Paul Menzel.
Yu-Ping Wu has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/83652?usp=email )
Change subject: arch/arm64/armv8/mmu: Improve log format ......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83652/comment/99b5ffb7_2090fcdd?usp... : PS2, Line 9: When using format string with "%p", "(nil)" will be printed for address
I'm curious where you see this? coreboot's `vtxprintf()` doesn't do this as far as I can tell.
See this in unit tests, not on a real ARM device. Let me modify the commit message.
File src/arch/arm64/armv8/mmu.c:
https://review.coreboot.org/c/coreboot/+/83652/comment/43c1a870_a2f7b696?usp... : PS2, Line 60: /* Func : table_level_name : * Desc : Get the descriptions table level name from the given size. : */
The code in this file precedes those style decisions, and until someone has time to update the whole […]
Thanks Paul for pointing this out. I did notice the wrong style in this file when writing this function. However I thought style consistency is more important, so I chose the following the existing style.