Attention is currently required from: Arthur Heymans, Timothy Pearson, Ron Minnich.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57084 )
Change subject: src/arch/ppc64/*: pass FDT address to payload
......................................................................
Patch Set 14:
(2 comments)
Patchset:
PS13:
Hmm wouldn't a linkerscript symbol shared in early stages, that you then move the cbmem in ramstage […]
Thought handoff would be a more "correct" solution, but yeah it's just uglier.
File src/arch/ppc64/fdt.h:
https://review.coreboot.org/c/coreboot/+/57084/comment/00a106d6_96e65684
PS13, Line 9: CBMEM_ID_FDT_ADDRESS
CBMEM_ID are to be placed in commonlib/include/commonlib/cbmem_id. […]
I thought it's too specific to the platform to put there. Moved.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57084
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0911f4b534c6f8cacfa057a5bad7576fec711637
Gerrit-Change-Number: 57084
Gerrit-PatchSet: 14
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Ron Minnich
rminnich@gmail.com
Gerrit-Reviewer: Timothy Pearson
tpearson@raptorengineering.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Timothy Pearson
tpearson@raptorengineering.com
Gerrit-Attention: Ron Minnich
rminnich@gmail.com
Gerrit-Comment-Date: Sat, 20 Nov 2021 00:35:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment