Attention is currently required from: Jean Lucas, Nicholas Chin, Nico Huber.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81861?usp=email )
Change subject: nb/intel/gm45: Fill in memory info
......................................................................
Patch Set 3:
(1 comment)
File src/northbridge/intel/gm45/raminit_meminfo.c:
https://review.coreboot.org/c/coreboot/+/81861/comment/de3f4446_abf3af3d :
PS1, Line 61: FOR_EACH_POPULATED_RANK
This is wrong, dual-rank DIMMs end up with two entries
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81861?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I92060ce05bdf0ca617a3383a2db1fdbd43df6fe4
Gerrit-Change-Number: 81861
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jean Lucas
Gerrit-Reviewer: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Jean Lucas
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Comment-Date: Tue, 16 Apr 2024 13:57:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment