Attention is currently required from: Martin L Roth, Matt DeVillier, Lean Sheng Tan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69202 )
Change subject: lib/ramtest.c: Update ram failure post code
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File src/lib/ramtest.c:
https://review.coreboot.org/c/coreboot/+/69202/comment/a31905e0_e97ace8f
PS1, Line 113: POST_RAM_FAILURE
maybe just for the 2nd one since this is nodie()
Right, nothing to do here.
https://review.coreboot.org/c/coreboot/+/69202/comment/74dd310d_ec2eb8ce
PS1, Line 203: POST_RAM_FAILURE
same as above
Yes, we should use `die_with_post_code()`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69202
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I21ef196e48ff37ffe320b575d6de66b43997e7eb
Gerrit-Change-Number: 69202
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Sat, 05 Nov 2022 09:53:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Gerrit-MessageType: comment