Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Jérémy Compostella, Matt DeVillier.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79261?usp=email )
Change subject: cpu/x86/64bit: Turn jumping to long mode into a macro
......................................................................
Patch Set 4:
(1 comment)
File src/cpu/qemu-x86/cache_as_ram_bootblock.S:
https://review.coreboot.org/c/coreboot/+/79261/comment/a66f0657_58050705 :
PS4, Line 83: setup_longmode $(CONFIG_ARCH_X86_64_PGTBL_LOC)
this looks to me like it fixed a bug by moving the long mode entry into the #if ENV_X86_64 guards. if this is true, it would be good to either mention that in the commit message or do that in a separate patch
Hmm entry64.inc actually guards everything, so nothing changes. I'll move it to a separate patch.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79261?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ida861338004187e4e714be41e17c8447fa4cf935
Gerrit-Change-Number: 79261
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 06 Feb 2024 14:26:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment