Attention is currently required from: Mingjin Ge, Yu-Ping Wu.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84024?usp=email )
Change subject: mb/google/rauru: reset usb hub in bootblock
......................................................................
Patch Set 8:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84024/comment/64da094c_5ec48ba0?usp... :
PS7, Line 13:
No Signed-off-by line in commit message
Done
File src/mainboard/google/rauru/bootblock.c:
https://review.coreboot.org/c/coreboot/+/84024/comment/f81aa153_c7bf52ea?usp... :
PS7, Line 4: #include "gpio.h"
Put it in a separate section. See geralt/bootblock.c as an example.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84024?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iea793b4b04bd009d0354e2331604bccf30466a23
Gerrit-Change-Number: 84024
Gerrit-PatchSet: 8
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Mingjin Ge
mingjin.ge@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Yidi Lin
yidilin@google.com
Gerrit-Attention: Mingjin Ge
mingjin.ge@mediatek.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Tue, 27 Aug 2024 11:59:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com