Attention is currently required from: Brandon Breitenstein, Paul Menzel. Vijay P Hiremath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56839 )
Change subject: mb/adlrvp: Add new board variant for MECC1727 ......................................................................
Patch Set 1:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56839/comment/6255aec9_15db33cc PS1, Line 7: MECC1727 replaces as MCHP1727 everywhere
https://review.coreboot.org/c/coreboot/+/56839/comment/60886c19_a42f7aa7 PS1, Line 9: MECC1727 add in card on rvp MCHP1727 Modular Embedded Controller Card on Intel Reference Validation Platform.
https://review.coreboot.org/c/coreboot/+/56839/comment/597b5aa7_e30fd46b PS1, Line 10:
What kind of card is the MECC1727 exactly?
its a EC card for RVP
File src/mainboard/intel/adlrvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/56839/comment/f94967f2_cf81abc1 PS1, Line 1: BOARD_INTEL_ADLRVP_P_MCHP add ADL RVP-M as well
File src/mainboard/intel/adlrvp/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/56839/comment/113597f9_d002baa2 PS1, Line 14: BOARD_INTEL_ADLRVP_P_MCHP add ADL-RVP M as well
File src/mainboard/intel/adlrvp/variants/adlrvp_p_mchp/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/56839/comment/71bc4eed_2c1146c3 PS1, Line 8: se conn2 as mux_conn[2] only two Type-C ports are planned for MEC1727 EC
https://review.coreboot.org/c/coreboot/+/56839/comment/0f4ce159_ca83eb0c PS1, Line 30: end : chip drivers/intel/pmc_mux/conn : register "usb2_port_number" = "3" : register "usb3_port_number" = "3" : # SBU is fixed, HSL follows CC : register "sbu_orientation" = "TYPEC_ORIE only two Type-C ports are planned for MEC1727 EC
-
Vijay P Hiremath (Code Review)