Attention is currently required from: Gwendal Grignou. SH Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59609 )
Change subject: mb/google/dedede: Add SAR sensor for bugzzy ......................................................................
Patch Set 3:
(6 comments)
Patchset:
PS3: Thanks for the patch!
File src/mainboard/google/dedede/variants/bugzzy/gpio.c:
https://review.coreboot.org/c/coreboot/+/59609/comment/15360cf9_52145aa5 PS3, Line 51: /* E11 : WIFI_SAR_SENSOR_INT */ : PAD_CFG_GPI_APIC(GPP_E11, NONE, PLTRST, LEVEL, NONE), We will not add Wifi P-sensor for bugzzy, so we can disable I2C5 port and remove the device from tree.
File src/mainboard/google/dedede/variants/bugzzy/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/59609/comment/5cb817c2_aca0468d PS3, Line 51: [PchSerialIoIndexI2C5] = PchSerialIoPci, We will not add Wifi P-sensor for bugzzy, so we can disable I2C5 port and remove the device from tree.
https://review.coreboot.org/c/coreboot/+/59609/comment/79b497e1_63aebf86 PS3, Line 67: #| I2C5 | P-sensor(Wifi) | We will not add Wifi P-sensor for bugzzy, so we can disable I2C5 port and remove the device from tree.
https://review.coreboot.org/c/coreboot/+/59609/comment/6dc18130_f2116cc5 PS3, Line 239: #register "generic.probed" = "1" We don't need it.
https://review.coreboot.org/c/coreboot/+/59609/comment/7a68fb2b_4cf7843d PS3, Line 338: device pci 19.1 on : chip drivers/i2c/sx9360 : register "desc" = ""SAR Proximity Sensor - Wifi"" : register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_E11_IRQ)" : register "uid" = "2" : register "proxraw_strength" = "2" : register "avg_pos_strength" = "16" : register "resolution" = "1024" : device i2c 28 on end : end : end #I2C 5 We will not add Wifi P-sensor for bugzzy, so we can disable I2C5 port and remove the device from tree.
-
SH Kim (Code Review)