[M] Change in coreboot[master]: Make Ada a first class citizen - coreboot-gerrit

6 Jul 2024


      Nico Huber has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/13044?usp=email )
Change subject: Make Ada a first class citizen
......................................................................
Patch Set 16:
(1 comment)
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/13044/comment/607e19c7_0cef9114?usp... :
PS16, Line 362: +=
...
I mean as it is the first time `ADAFLAGS_common ` is used here, why you used `+=` instead of ` := `  […]
I just mimicked `CFLAGS_common` I guess. The difference is subtle and if
we did the right thing wrt. future changes can only be decided in the future.
Generally, I like to think about the various `Makefile.mk`s that their order
shouldn't matter.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/13044?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70df9adbd467ecd2dc7c5c1cf418b7765aca4e93
Gerrit-Change-Number: 13044
Gerrit-PatchSet: 16
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Edward O'Callaghan edward.ocallaghan@koparo.com
Gerrit-Reviewer: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Elyes Haouas ehaouas@noos.fr
Gerrit-Comment-Date: Sat, 06 Jul 2024 11:21:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Elyes Haouas ehaouas@noos.fr