Fred Reitberger has submitted this change. ( https://review.coreboot.org/c/coreboot/+/71847 )
Change subject: soc/amd/phoenix: Use common fsp-s preloader ......................................................................
soc/amd/phoenix: Use common fsp-s preloader
Use the common preloader for fsp-s
Signed-off-by: Fred Reitberger reitbergerfred@gmail.com Change-Id: Iea7011d37667f3f04ce842038346741fba66b1dc Reviewed-on: https://review.coreboot.org/c/coreboot/+/71847 Reviewed-by: Felix Held felix-coreboot@felixheld.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/phoenix/Kconfig M src/soc/amd/phoenix/Makefile.inc D src/soc/amd/phoenix/preload.c 3 files changed, 16 insertions(+), 14 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
diff --git a/src/soc/amd/phoenix/Kconfig b/src/soc/amd/phoenix/Kconfig index f39a73d..fc79ad8 100644 --- a/src/soc/amd/phoenix/Kconfig +++ b/src/soc/amd/phoenix/Kconfig @@ -72,6 +72,7 @@ select SOC_AMD_COMMON_FSP_CCX_CPPC_HOB # TODO: Check if this is still correct select SOC_AMD_COMMON_FSP_DMI_TABLES # TODO: Check if this is still correct select SOC_AMD_COMMON_FSP_PCI # TODO: Check if this is still correct + select SOC_AMD_COMMON_FSP_PRELOAD_FSPS select SSE2 select UDK_2017_BINDING select USE_DDR5 diff --git a/src/soc/amd/phoenix/Makefile.inc b/src/soc/amd/phoenix/Makefile.inc index 71defcf..25eed12 100644 --- a/src/soc/amd/phoenix/Makefile.inc +++ b/src/soc/amd/phoenix/Makefile.inc @@ -40,7 +40,6 @@ ramstage-y += gpio.c ramstage-y += i2c.c ramstage-y += mca.c -ramstage-y += preload.c ramstage-y += reset.c ramstage-y += root_complex.c ramstage-y += uart.c diff --git a/src/soc/amd/phoenix/preload.c b/src/soc/amd/phoenix/preload.c deleted file mode 100644 index 47f3580..0000000 --- a/src/soc/amd/phoenix/preload.c +++ /dev/null @@ -1,13 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -/* TODO: Move to common? */ - -#include <bootstate.h> -#include <fsp/api.h> - -static void start_fsps_preload(void *unused) -{ - preload_fsps(); -} - -BOOT_STATE_INIT_ENTRY(BS_PRE_DEVICE, BS_ON_ENTRY, start_fsps_preload, NULL);