Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38978 )
Change subject: [WIP] mainboard: Add Acer ES1-572 ......................................................................
Patch Set 5:
(6 comments)
https://review.coreboot.org/c/coreboot/+/38978/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38978/5//COMMIT_MSG@19 PS5, Line 19: - Loading Linux with SeaBIOS and tianocore booting linux with grub2 works fine, too
https://review.coreboot.org/c/coreboot/+/38978/5//COMMIT_MSG@20 PS5, Line 20: - Power button soldered onto the board's debug pads. -> maybe add that to Documentation/mb/...
https://review.coreboot.org/c/coreboot/+/38978/5//COMMIT_MSG@21 PS5, Line 21: - UART 2 to get yelled at -> maybe add info on how to access that + resistor names to Documentation/mb/...
https://review.coreboot.org/c/coreboot/+/38978/5//COMMIT_MSG@27 PS5, Line 27: similar to KB9012 and probably KB932
https://review.coreboot.org/c/coreboot/+/38978/5//COMMIT_MSG@29 PS5, Line 29: - Internal eDP LCD. I think I have the cable somewhere.
works fine. tested with grub.
... and now with linux (console only tested)
https://review.coreboot.org/c/coreboot/+/38978/5//COMMIT_MSG@33 PS5, Line 33: . final period(s) in a listing? o.O