Attention is currently required from: Arthur Heymans, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63004 )
Change subject: Move common EFI and FSP definitions to commonlib ......................................................................
Patch Set 3:
(4 comments)
File src/commonlib/include/commonlib/uefi_types.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144483): https://review.coreboot.org/c/coreboot/+/63004/comment/765fa55b_5dcf57d6 PS3, Line 9: #define SIGNATURE_32(A, B, C, D) (SIGNATURE_16 (A, B) | (SIGNATURE_16 (C, D) << 16)) space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144483): https://review.coreboot.org/c/coreboot/+/63004/comment/37e00b1d_444625b4 PS3, Line 9: #define SIGNATURE_32(A, B, C, D) (SIGNATURE_16 (A, B) | (SIGNATURE_16 (C, D) << 16)) space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144483): https://review.coreboot.org/c/coreboot/+/63004/comment/129a6ef9_1637b8a0 PS3, Line 13: #define EFI_FVH_SIGNATURE SIGNATURE_32 ('_', 'F', 'V', 'H') space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144483): https://review.coreboot.org/c/coreboot/+/63004/comment/07d53882_6c133624 PS3, Line 13: #define EFI_FVH_SIGNATURE SIGNATURE_32 ('_', 'F', 'V', 'H') Macros with complex values should be enclosed in parentheses
-
build bot (Jenkins) (Code Review)