Attention is currently required from: Martin Roth, Arthur Heymans, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50928 )
Change subject: security/intel/cbnt: Add options to generate BPM from Kconfig
......................................................................
Patch Set 30: Code-Review+1
(3 comments)
File src/security/intel/cbnt/Kconfig:
https://review.coreboot.org/c/coreboot/+/50928/comment/ca1d9671_17e35e52
PS30, Line 186: INTEL_CBNT_NEMS
How about `INTEL_CBNT_NUM_NEM_PAGES` instead?
https://review.coreboot.org/c/coreboot/+/50928/comment/981f4dc8_7bc29a8f
PS30, Line 192: config INTEL_CBNT_PBET
Which units? Potatoes per cubic feet? 😜
https://review.coreboot.org/c/coreboot/+/50928/comment/e66fb81a_b453dd84
PS30, Line 199: int
Would hex make more sense here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50928
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9f5ffa0f692b06265f992b07a44763ff1aa8dfa7
Gerrit-Change-Number: 50928
Gerrit-PatchSet: 30
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 29 Mar 2021 13:25:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment