Attention is currently required from: Tarun Tuli, Subrata Banik, Johnny Lin, Dinesh Gehlot, David Hendricks, Kapil Porwal, Christian Walter, Werner Zeh, Tim Chu.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72604 )
Change subject: soc/intel: Use common codeflow for MP init
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
CPU frequency seems to be dropping with the changes. On ToT bin it was ~1200MHz but it drops to ~400MHz for few cases with changes for rex.
Steps to reproduce:
- Check CPU information from AP console.
- Compare all occurrence of key word "CPU MHz"
localhost ~ cat /proc/cpuinfo
That's really strange as the bootflow is pretty much identical. No new code is run.
Are you sure CPU freq change is not to be expected? You can see what power states are expected with powertop. cpuinfo just shows the current cpu freq which depends on the load.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72604
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia822468a6f15565b97e57612a294a0b80b45b932
Gerrit-Change-Number: 72604
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Tue, 07 Feb 2023 10:26:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Dinesh Gehlot
digehlot@google.com
Gerrit-MessageType: comment