Attention is currently required from: Timofey Komarov, Felix Singer, Nico Huber, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52692 )
Change subject: soc/intel/skylake: Allow to use Amber Lake FSP ......................................................................
Patch Set 5: Code-Review+1
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52692/comment/46b36800_51eb0157 PS5, Line 15: mainboard nit: move to previous line
File src/soc/intel/skylake/Kconfig:
https://review.coreboot.org/c/coreboot/+/52692/comment/da1d257e_199425af PS5, Line 95: default 16 if MAINBOARD_SUPPORTS_COFFEELAKE_CPU I'd do this in CB:52693
https://review.coreboot.org/c/coreboot/+/52692/comment/e9e29bdf_1786dd22 PS5, Line 256: # SkylakeFsp is FSP 1.1 and therefore incompatible. Why move the comment?
https://review.coreboot.org/c/coreboot/+/52692/comment/317a0fd1_a9da863c PS5, Line 259: if SOC_INTEL_SKYLAKE_LGA1151_V2 No need to break the line, this fits in 96 characters
https://review.coreboot.org/c/coreboot/+/52692/comment/125347b7_76fb012b PS5, Line 264: if SOC_INTEL_SKYLAKE_LGA1151_V2 No need to break the line, this fits in 96 characters