Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27369 )
Change subject: soc/intel/basecode: Add support for updating ucode loaded via FIT
......................................................................
Patch Set 46:
(4 comments)
https://review.coreboot.org/c/coreboot/+/27369/36//COMMIT_MSG
Commit Message:
PS36:
Just for the future (not saying you should change it here as […]
Done
https://review.coreboot.org/c/coreboot/+/27369/19/src/soc/intel/common/basec...
File src/soc/intel/common/basecode/fw_update/ucode_update.c:
https://review.coreboot.org/c/coreboot/+/27369/19/src/soc/intel/common/basec...
PS19, Line 92: boot_device_rw_subregion(&st_region, &write_rdev) < 0)
I thought it is cleaner and avoid fmap_parsing. […]
Done
https://review.coreboot.org/c/coreboot/+/27369/19/src/soc/intel/common/basec...
PS19, Line 92: boot_device_rw_subregion(&st_region, &write_rdev) < 0)
I thought it is cleaner and avoid fmap_parsing. […]
Done
https://review.coreboot.org/c/coreboot/+/27369/30/src/soc/intel/common/basec...
File src/soc/intel/common/basecode/fw_update/ucode_update.c:
https://review.coreboot.org/c/coreboot/+/27369/30/src/soc/intel/common/basec...
PS30, Line 103: static int protect_staging(void)
Claim an FPR and set the range as soon as you get an opportunity. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/27369
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iab6ba36a2eb587f331fe522c778e2c430c8eb655
Gerrit-Change-Number: 27369
Gerrit-PatchSet: 46
Gerrit-Owner: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: dhaval v sharma
dhaval.v.sharma@intel.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Dhaval Sharma
dhaval.v.sharma@intel.corp-partner.google.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: rushikesh s kadam
rushikesh.s.kadam@intel.com
Gerrit-Comment-Date: Mon, 16 Sep 2019 06:31:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Rizwan Qureshi
rizwan.qureshi@intel.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment