Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83509?usp=email )
Change subject: device/pci_ids: Add new Intel PTL device IDs for I2Cx ......................................................................
device/pci_ids: Add new Intel PTL device IDs for I2Cx
This patch adds new I2Cx PCI device IDs for Intel PTL-U and PTL-H.
Additionally, updates the I2C driver's `pci_device_ids` list to include these new IDs.
Source: Intel PTL-EDS vol 1. Document Number 815002, Rev 0.51 Chapter 2
BUG=b:347669091 TEST=Able to build google/fatcat.
Change-Id: I79ba0b563146d658521cdd40aabb3ee882f4d187 Signed-off-by: Subrata Banik subratabanik@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/83509 Reviewed-by: Eric Lai ericllai@google.com Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/include/device/pci_ids.h M src/soc/intel/common/block/i2c/i2c.c 2 files changed, 24 insertions(+), 12 deletions(-)
Approvals: Angel Pons: Looks good to me, but someone else must approve build bot (Jenkins): Verified Eric Lai: Looks good to me, approved
diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index c7b875c..967f657 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -3900,12 +3900,18 @@ #define PCI_DID_INTEL_LNL_I2C4 0xa850 #define PCI_DID_INTEL_LNL_I2C5 0xa851
-#define PCI_DID_INTEL_PTL_I2C0 0xe478 -#define PCI_DID_INTEL_PTL_I2C1 0xe479 -#define PCI_DID_INTEL_PTL_I2C2 0xe47a -#define PCI_DID_INTEL_PTL_I2C3 0xe47b -#define PCI_DID_INTEL_PTL_I2C4 0xe450 -#define PCI_DID_INTEL_PTL_I2C5 0xe451 +#define PCI_DID_INTEL_PTL_H_I2C0 0xe478 +#define PCI_DID_INTEL_PTL_H_I2C1 0xe479 +#define PCI_DID_INTEL_PTL_H_I2C2 0xe47a +#define PCI_DID_INTEL_PTL_H_I2C3 0xe47b +#define PCI_DID_INTEL_PTL_H_I2C4 0xe450 +#define PCI_DID_INTEL_PTL_H_I2C5 0xe451 +#define PCI_DID_INTEL_PTL_U_H_I2C0 0xe378 +#define PCI_DID_INTEL_PTL_U_H_I2C1 0xe379 +#define PCI_DID_INTEL_PTL_U_H_I2C2 0xe37a +#define PCI_DID_INTEL_PTL_U_H_I2C3 0xe37b +#define PCI_DID_INTEL_PTL_U_H_I2C4 0xe350 +#define PCI_DID_INTEL_PTL_U_H_I2C5 0xe351
/* Intel UART device Ids */ #define PCI_DID_INTEL_LPT_LP_UART0 0x9c63 diff --git a/src/soc/intel/common/block/i2c/i2c.c b/src/soc/intel/common/block/i2c/i2c.c index f84b2cd..679d425 100644 --- a/src/soc/intel/common/block/i2c/i2c.c +++ b/src/soc/intel/common/block/i2c/i2c.c @@ -174,12 +174,18 @@ };
static const unsigned short pci_device_ids[] = { - PCI_DID_INTEL_PTL_I2C0, - PCI_DID_INTEL_PTL_I2C1, - PCI_DID_INTEL_PTL_I2C2, - PCI_DID_INTEL_PTL_I2C3, - PCI_DID_INTEL_PTL_I2C4, - PCI_DID_INTEL_PTL_I2C5, + PCI_DID_INTEL_PTL_H_I2C0, + PCI_DID_INTEL_PTL_H_I2C1, + PCI_DID_INTEL_PTL_H_I2C2, + PCI_DID_INTEL_PTL_H_I2C3, + PCI_DID_INTEL_PTL_H_I2C4, + PCI_DID_INTEL_PTL_H_I2C5, + PCI_DID_INTEL_PTL_U_H_I2C0, + PCI_DID_INTEL_PTL_U_H_I2C1, + PCI_DID_INTEL_PTL_U_H_I2C2, + PCI_DID_INTEL_PTL_U_H_I2C3, + PCI_DID_INTEL_PTL_U_H_I2C4, + PCI_DID_INTEL_PTL_U_H_I2C5, PCI_DID_INTEL_LNL_I2C0, PCI_DID_INTEL_LNL_I2C1, PCI_DID_INTEL_LNL_I2C2,
-
Subrata Banik (Code Review)