Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45433 )
Change subject: nb/intel/gm45: Drop unused `DEFAULT_HECIBAR` macro ......................................................................
nb/intel/gm45: Drop unused `DEFAULT_HECIBAR` macro
Change-Id: I9e074689cd5a11d58b788b789654f3a3beb83a65 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/gm45/gm45.h 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/45433/1
diff --git a/src/northbridge/intel/gm45/gm45.h b/src/northbridge/intel/gm45/gm45.h index 758e197..cdd325d 100644 --- a/src/northbridge/intel/gm45/gm45.h +++ b/src/northbridge/intel/gm45/gm45.h @@ -174,7 +174,6 @@ #define DEFAULT_MCHBAR 0xfed14000 #define DEFAULT_DMIBAR 0xfed18000 #define DEFAULT_EPBAR 0xfed19000 -#define DEFAULT_HECIBAR ((u8 *)0xfed1a000)
#define IOMMU_BASE1 0xfed90000
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45433 )
Change subject: nb/intel/gm45: Drop unused `DEFAULT_HECIBAR` macro ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45433 )
Change subject: nb/intel/gm45: Drop unused `DEFAULT_HECIBAR` macro ......................................................................
nb/intel/gm45: Drop unused `DEFAULT_HECIBAR` macro
Change-Id: I9e074689cd5a11d58b788b789654f3a3beb83a65 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45433 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org --- M src/northbridge/intel/gm45/gm45.h 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved
diff --git a/src/northbridge/intel/gm45/gm45.h b/src/northbridge/intel/gm45/gm45.h index 6f8d53c..e4aff39 100644 --- a/src/northbridge/intel/gm45/gm45.h +++ b/src/northbridge/intel/gm45/gm45.h @@ -173,7 +173,6 @@ #define DEFAULT_MCHBAR 0xfed14000 #define DEFAULT_DMIBAR 0xfed18000 #define DEFAULT_EPBAR 0xfed19000 -#define DEFAULT_HECIBAR ((u8 *)0xfed1a000)
#define IOMMU_BASE1 0xfed90000 #define IOMMU_BASE2 0xfed91000
-
Angel Pons (Code Review) -
Patrick Rudolph (Code Review)