[L] Change in coreboot[main]: mainboard/dell: Add new mainboard XPS 8300 (Sandy Bridge) - coreboot-gerrit

8 Jul 2024


      Attention is currently required from: Ronald Claveau.
Felix Singer has posted comments on this change by Ronald Claveau. ( https://review.coreboot.org/c/coreboot/+/83104?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mainboard/dell: Add new mainboard XPS 8300 (Sandy Bridge)
......................................................................
Patch Set 15:
(1 comment)
File src/mainboard/dell/xps_8300/board.fmd:
PS15: 
Just stumbled upon this. Is that really needed? Looks like you can just add CBFS_SIZE to Kconfig and the build system generates a similar FMAP.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/83104?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7d394794fec580bc7aed3f6396ceb47d4a6fd059
Gerrit-Change-Number: 83104
Gerrit-PatchSet: 15
Gerrit-Owner: Ronald Claveau sousmangoosta@aliel.fr
Gerrit-Reviewer: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Elyes Haouas ehaouas@noos.fr
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Ronald Claveau sousmangoosta@aliel.fr
Gerrit-Comment-Date: Mon, 08 Jul 2024 15:42:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No