Hello Arthur Heymans, Jonathan Neuschäfer, Philipp Hug,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/36610
to review the following change.
Change subject: arch/x86/riscv: Don't link `stages.c` into ramstage ......................................................................
arch/x86/riscv: Don't link `stages.c` into ramstage
It's superseded by `ramstage.S`.
Change-Id: I81648da2f2af3ad73b3b51471c6fa2daac0540b1 Signed-off-by: Nico Huber nico.h@gmx.de --- M src/arch/riscv/Makefile.inc 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/36610/1
diff --git a/src/arch/riscv/Makefile.inc b/src/arch/riscv/Makefile.inc index 0039fab..16f160e 100644 --- a/src/arch/riscv/Makefile.inc +++ b/src/arch/riscv/Makefile.inc @@ -140,7 +140,6 @@ ramstage-y += misaligned.c ramstage-y += sbi.c ramstage-y += virtual_memory.c -ramstage-y += stages.c ramstage-y += misc.c ramstage-y += smp.c ramstage-y += boot.c
Hello ron minnich, Arthur Heymans, Jonathan Neuschäfer, build bot (Jenkins), Patrick Georgi, Martin Roth, Philipp Hug,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36610
to look at the new patch set (#2).
Change subject: arch/riscv: Don't link `stages.c` into ramstage ......................................................................
arch/riscv: Don't link `stages.c` into ramstage
It's superseded by `ramstage.S`.
Change-Id: I81648da2f2af3ad73b3b51471c6fa2daac0540b1 Signed-off-by: Nico Huber nico.h@gmx.de --- M src/arch/riscv/Makefile.inc 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/36610/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36610 )
Change subject: arch/riscv: Don't link `stages.c` into ramstage ......................................................................
Patch Set 2: Code-Review+1
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36610 )
Change subject: arch/riscv: Don't link `stages.c` into ramstage ......................................................................
Patch Set 2: Code-Review+2
Heh
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36610 )
Change subject: arch/riscv: Don't link `stages.c` into ramstage ......................................................................
arch/riscv: Don't link `stages.c` into ramstage
It's superseded by `ramstage.S`.
Change-Id: I81648da2f2af3ad73b3b51471c6fa2daac0540b1 Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/36610 Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Arthur Heymans arthur@aheymans.xyz Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/arch/riscv/Makefile.inc 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Arthur Heymans: Looks good to me, approved
diff --git a/src/arch/riscv/Makefile.inc b/src/arch/riscv/Makefile.inc index 0039fab..16f160e 100644 --- a/src/arch/riscv/Makefile.inc +++ b/src/arch/riscv/Makefile.inc @@ -140,7 +140,6 @@ ramstage-y += misaligned.c ramstage-y += sbi.c ramstage-y += virtual_memory.c -ramstage-y += stages.c ramstage-y += misc.c ramstage-y += smp.c ramstage-y += boot.c
-
Arthur Heymans (Code Review) -
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)