Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33745
Change subject: cpu/amd/family_10h-family_15h: Remove dead assignment ......................................................................
cpu/amd/family_10h-family_15h: Remove dead assignment
Pstate_num is initialized later when it is used as a loop index, so this duplicate assignment can be removed.
Change-Id: I71429bd3306139a823ed39e751d779e4d874f657 Signed-off-by: Jacob Garber jgarber1@ualberta.ca Found-by: scan-build 8.0.0 --- M src/cpu/amd/family_10h-family_15h/powernow_acpi.c 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/33745/1
diff --git a/src/cpu/amd/family_10h-family_15h/powernow_acpi.c b/src/cpu/amd/family_10h-family_15h/powernow_acpi.c index e648b71..be936f6 100644 --- a/src/cpu/amd/family_10h-family_15h/powernow_acpi.c +++ b/src/cpu/amd/family_10h-family_15h/powernow_acpi.c @@ -259,8 +259,6 @@ else if (mctGetLogicalCPUID(0) & AMD_FAM15_ALL) boost_count = (dtemp >> 2) & 0x7;
- Pstate_num = 0; - /* See if the CPUID(0x80000007) returned EDX[7]==1b */ cpuid1 = cpuid(0x80000007); if ((cpuid1.edx & 0x80) != 0x80) {
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33745 )
Change subject: cpu/amd/family_10h-family_15h: Remove dead assignment ......................................................................
Patch Set 1: Code-Review+2
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33745 )
Change subject: cpu/amd/family_10h-family_15h: Remove dead assignment ......................................................................
cpu/amd/family_10h-family_15h: Remove dead assignment
Pstate_num is initialized later when it is used as a loop index, so this duplicate assignment can be removed.
Change-Id: I71429bd3306139a823ed39e751d779e4d874f657 Signed-off-by: Jacob Garber jgarber1@ualberta.ca Found-by: scan-build 8.0.0 Reviewed-on: https://review.coreboot.org/c/coreboot/+/33745 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/cpu/amd/family_10h-family_15h/powernow_acpi.c 1 file changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/cpu/amd/family_10h-family_15h/powernow_acpi.c b/src/cpu/amd/family_10h-family_15h/powernow_acpi.c index e648b71..be936f6 100644 --- a/src/cpu/amd/family_10h-family_15h/powernow_acpi.c +++ b/src/cpu/amd/family_10h-family_15h/powernow_acpi.c @@ -259,8 +259,6 @@ else if (mctGetLogicalCPUID(0) & AMD_FAM15_ALL) boost_count = (dtemp >> 2) & 0x7;
- Pstate_num = 0; - /* See if the CPUID(0x80000007) returned EDX[7]==1b */ cpuid1 = cpuid(0x80000007); if ((cpuid1.edx & 0x80) != 0x80) {
-
Angel Pons (Code Review) -
Jacob Garber (Code Review)
-
Martin Roth (Code Review)