Change in coreboot[master]: soc/amd/picasso/acpi,mb/google/zork: Stop clearing PciExpWakeStatus

[Raul Rangel (Code Review)]

Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43428 )

Change subject: soc/amd/picasso/acpi,mb/google/zork: Stop clearing PciExpWakeStatus
......................................................................

soc/amd/picasso/acpi,mb/google/zork: Stop clearing PciExpWakeStatus

The kernel already clears this: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/th...
No reason to have the firmware do it as well.

BUG=b:153001807, b:154756391
TEST=Build Trembyle, boot, suspend, and resume and didn't see any ACPI
errors.

Signed-off-by: Raul E Rangel 
Change-Id: Ia5c79fb95dc885eaef8abc4257b6ba18c1ef1b66
---
M src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/sleep.asl
M src/soc/amd/picasso/acpi/pcie.asl
2 files changed, 17 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/43428/1

diff --git a/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/sleep.asl b/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/sleep.asl
index 3061596..a5b98df 100644
--- a/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/sleep.asl
+++ b/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/sleep.asl
@@ -21,8 +21,6 @@
    /* DBGO("From S0 to S") */
    /* DBGO(Arg0) */
    /* DBGO("\n") */
-
-	Store(0, PEWD)
 } /* End Method(_PTS) */

/*
diff --git a/src/soc/amd/picasso/acpi/pcie.asl b/src/soc/amd/picasso/acpi/pcie.asl
index 83da985..cb4be7f 100644
--- a/src/soc/amd/picasso/acpi/pcie.asl
+++ b/src/soc/amd/picasso/acpi/pcie.asl
@@ -64,3 +64,20 @@
    	IUA3, 0x00000008,	/* Index 0xF9: UART3 */
    }

+	/* Power Management I/O registers, TODO:PMIO is quite different in SB800. */
+	OperationRegion(PIOR, SystemIO, 0x00000Cd6, 0x00000002)
+		Field(PIOR, ByteAcc, NoLock, Preserve) {
+		PIOI, 0x00000008,
+		PIOD, 0x00000008,
+	}
+
+	IndexField (PIOI, PIOD, ByteAcc, NoLock, Preserve) {
+		Offset(0x60),		/* AcpiPm1EvgBlk */
+		P1EB, 16,
+	}
+	OperationRegion (P1E0, SystemIO, P1EB, 0x04)
+		Field (P1E0, ByteAcc, Nolock, Preserve) {
+		Offset(0x02),
+		, 14,
+		PEWD, 1,
+	}

[Raul Rangel (Code Review)]

Raul Rangel has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/43428 )

Change subject: soc/amd/picasso/acpi,mb/google/zork: Stop clearing PciExpWakeStatus
......................................................................

soc/amd/picasso/acpi,mb/google/zork: Stop clearing PciExpWakeStatus

The kernel already clears this: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/th...
No reason to have the firmware do it as well.

BUG=b:153001807, b:154756391
TEST=Build Trembyle, boot, suspend, and resume and didn't see any ACPI
errors.

Signed-off-by: Raul E Rangel 
Change-Id: Ia5c79fb95dc885eaef8abc4257b6ba18c1ef1b66
---
M src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/sleep.asl
M src/soc/amd/picasso/acpi/pcie.asl
2 files changed, 0 insertions(+), 20 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/43428/2

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43428 )

Change subject: soc/amd/picasso/acpi,mb/google/zork: Stop clearing PciExpWakeStatus
......................................................................

Patch Set 2: Code-Review+2

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43428 )

Change subject: soc/amd/picasso/acpi,mb/google/zork: Stop clearing PciExpWakeStatus
......................................................................

Patch Set 2:

Like the other patch, mandolin is failing:

dsdt.asl    211:  Store(0, PEWD)
Error    6084 -              ^ Object does not exist (PEWD)

dsdt.asl    214:  Store(7, UPWS)
Error    6084 -              ^ Object does not exist (UPWS)

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43428 )

Change subject: soc/amd/picasso/acpi,mb/google/zork: Stop clearing PciExpWakeStatus
......................................................................

Patch Set 2: Code-Review+2

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43428 )

Change subject: soc/amd/picasso/acpi,mb/google/zork: Stop clearing PciExpWakeStatus
......................................................................

Patch Set 2: Code-Review+2

Change in coreboot[master]: soc/amd/picasso/acpi,mb/{zork,mandolin}: Stop clearing PciExpWakeStatus

[Raul Rangel (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Angel Pons, Aaron Durbin, Felix Held,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43428

to look at the new patch set (#3).

Change subject: soc/amd/picasso/acpi,mb/{zork,mandolin}: Stop clearing PciExpWakeStatus
......................................................................

soc/amd/picasso/acpi,mb/{zork,mandolin}: Stop clearing PciExpWakeStatus

The kernel already clears this: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/th...
No reason to have the firmware do it as well.

BUG=b:153001807, b:154756391
TEST=Build Trembyle, boot, suspend, and resume and didn't see any ACPI
errors.

Signed-off-by: Raul E Rangel 
Change-Id: Ia5c79fb95dc885eaef8abc4257b6ba18c1ef1b66
---
M src/mainboard/amd/mandolin/acpi/sleep.asl
M src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/sleep.asl
M src/soc/amd/picasso/acpi/pcie.asl
3 files changed, 0 insertions(+), 22 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/43428/3

Change in coreboot[master]: soc/amd/picasso/acpi,mb/{zork,mandolin}: Stop clearing PciExpWakeStatus

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43428 )

Change subject: soc/amd/picasso/acpi,mb/{zork,mandolin}: Stop clearing PciExpWakeStatus
......................................................................

Patch Set 3: Code-Review+2

Change in coreboot[master]: soc/amd/picasso/acpi,mb/{zork,mandolin}: Stop clearing PciExpWakeStatus

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43428 )

Change subject: soc/amd/picasso/acpi,mb/{zork,mandolin}: Stop clearing PciExpWakeStatus
......................................................................

Patch Set 3: Code-Review+2

Change in coreboot[master]: soc/amd/picasso/acpi,mb/{zork,mandolin}: Stop clearing PciExpWakeStatus

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43428 )

Change subject: soc/amd/picasso/acpi,mb/{zork,mandolin}: Stop clearing PciExpWakeStatus
......................................................................

soc/amd/picasso/acpi,mb/{zork,mandolin}: Stop clearing PciExpWakeStatus

The kernel already clears this: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/th...
No reason to have the firmware do it as well.

BUG=b:153001807, b:154756391
TEST=Build Trembyle, boot, suspend, and resume and didn't see any ACPI
errors.

Signed-off-by: Raul E Rangel 
Change-Id: Ia5c79fb95dc885eaef8abc4257b6ba18c1ef1b66
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43428
Tested-by: build bot (Jenkins) 
Reviewed-by: Aaron Durbin 
Reviewed-by: Furquan Shaikh 
---
M src/mainboard/amd/mandolin/acpi/sleep.asl
M src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/sleep.asl
M src/soc/amd/picasso/acpi/pcie.asl
3 files changed, 0 insertions(+), 22 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Aaron Durbin: Looks good to me, approved
  Furquan Shaikh: Looks good to me, approved

diff --git a/src/mainboard/amd/mandolin/acpi/sleep.asl b/src/mainboard/amd/mandolin/acpi/sleep.asl
index 6fdb30b..526754e 100644
--- a/src/mainboard/amd/mandolin/acpi/sleep.asl
+++ b/src/mainboard/amd/mandolin/acpi/sleep.asl
@@ -21,8 +21,6 @@
    /* DBGO("From S0 to S") */
    /* DBGO(Arg0) */
    /* DBGO("\n") */
-
-	Store(0, PEWD)
 } /* End Method(_PTS) */

/*
diff --git a/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/sleep.asl b/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/sleep.asl
index 267be30..4a62ecf 100644
--- a/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/sleep.asl
+++ b/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/sleep.asl
@@ -21,8 +21,6 @@
    /* DBGO("From S0 to S") */
    /* DBGO(Arg0) */
    /* DBGO("\n") */
-
-	Store(0, PEWD)
 } /* End Method(_PTS) */

/*
diff --git a/src/soc/amd/picasso/acpi/pcie.asl b/src/soc/amd/picasso/acpi/pcie.asl
index cb4be7f..601de52 100644
--- a/src/soc/amd/picasso/acpi/pcie.asl
+++ b/src/soc/amd/picasso/acpi/pcie.asl
@@ -63,21 +63,3 @@
    	IUA2, 0x00000008,	/* Index 0xF8: UART2 */
    	IUA3, 0x00000008,	/* Index 0xF9: UART3 */
    }
-
-	/* Power Management I/O registers, TODO:PMIO is quite different in SB800. */
-	OperationRegion(PIOR, SystemIO, 0x00000Cd6, 0x00000002)
-		Field(PIOR, ByteAcc, NoLock, Preserve) {
-		PIOI, 0x00000008,
-		PIOD, 0x00000008,
-	}
-
-	IndexField (PIOI, PIOD, ByteAcc, NoLock, Preserve) {
-		Offset(0x60),		/* AcpiPm1EvgBlk */
-		P1EB, 16,
-	}
-	OperationRegion (P1E0, SystemIO, P1EB, 0x04)
-		Field (P1E0, ByteAcc, Nolock, Preserve) {
-		Offset(0x02),
-		, 14,
-		PEWD, 1,
-	}