Karthik Ramasubramanian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/67384 )
Change subject: util/amdfwtool: Include the header with __packed definition ......................................................................
util/amdfwtool: Include the header with __packed definition
Checkpatch script recommends to use __packed instead of __attribute__((packed)). Currently the build rule for amdfwtool does not include the required header file with __packed definition. Update the compiler flag to include the required header file.
BUG=None TEST=Build amdfwtool.
Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com Change-Id: I448cbad533608dd5c2bd4f2d827fcc5db5dee5cb --- M util/amdfwtool/Makefile M util/amdfwtool/Makefile.inc 2 files changed, 21 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/67384/1
diff --git a/util/amdfwtool/Makefile b/util/amdfwtool/Makefile index bdc3dc3..1b4b824 100644 --- a/util/amdfwtool/Makefile +++ b/util/amdfwtool/Makefile @@ -1,5 +1,6 @@ # SPDX-License-Identifier: BSD-3-Clause
+top ?= $(abspath ../..) HOSTCC ?= cc
READ_SRC = amdfwread.c @@ -10,6 +11,7 @@ TARGETS = amdfwread amdfwtool WERROR=-Werror CFLAGS=-O2 -Wall -Wextra -Wshadow ${WERROR} +CFLAGS += -include $(top)/src/commonlib/bsd/include/commonlib/bsd/compiler.h
all: $(TARGETS)
diff --git a/util/amdfwtool/Makefile.inc b/util/amdfwtool/Makefile.inc index 4b7db76..d4fcd9b 100644 --- a/util/amdfwtool/Makefile.inc +++ b/util/amdfwtool/Makefile.inc @@ -3,6 +3,7 @@ amdfwtoolobj = amdfwtool.o data_parse.o
AMDFWTOOLCFLAGS=-O2 -Wall -Wextra -Wshadow -Werror +AMDFWTOOLCFLAGS += -include $(top)/src/commonlib/bsd/include/commonlib/bsd/compiler.h
$(objutil)/amdfwtool/%.o: $(top)/util/amdfwtool/%.c # $(HEADER) $(HOSTCC) $(AMDFWTOOLCFLAGS) $(HOSTCFLAGS) -c -o $@ $<