[XS] Change in coreboot[main]: Makefile: Move `--no-warn-rwx-segments' into xcompile

[Nico Huber (Code Review)]

Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83693?usp=email )

Change subject: Makefile: Move `--no-warn-rwx-segments' into xcompile
......................................................................

Makefile: Move `--no-warn-rwx-segments' into xcompile

The parameter is not available for binutils older than 2.39. So move it
to xcompile to provide backwards compatibility for a bit.

Change-Id: I02982769ae2c356f037a747e85d155368bfcb730
Signed-off-by: Nico Huber 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83693
Tested-by: build bot (Jenkins) 
Reviewed-by: Felix Singer 
---
M Makefile.mk
M util/xcompile/xcompile
2 files changed, 6 insertions(+), 3 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Felix Singer: Looks good to me, approved
  Nico Huber: Looks good to me, approved

diff --git a/Makefile.mk b/Makefile.mk
index e9ad2cc..901d6b2 100644
--- a/Makefile.mk
+++ b/Makefile.mk
@@ -604,9 +604,6 @@
 LDFLAGS_common += --nmagic
 LDFLAGS_common += -static
 LDFLAGS_common += -z noexecstack
-# Disable warning on segments with RWX.
-# All loadable sections are placed in the same segment for simplicity.
-LDFLAGS_common += --no-warn-rwx-segments

# Workaround for RISC-V linker bug, merge back into above line when fixed.
 # https://sourceware.org/bugzilla/show_bug.cgi?id=27180
diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile
index 4ead648..13ed48b 100755
--- a/util/xcompile/xcompile
+++ b/util/xcompile/xcompile
@@ -241,6 +241,12 @@
    testcc "$GCC"      "$CFLAGS_GCC -Wextra" &&
    	CFLAGS_GCC="$CFLAGS_GCC -Wextra"

+	# Disable warning on segments with RWX.
+	# All loadable sections are placed in the same segment for simplicity.
+	testld "$GCC" "$FLAGS_GCC" "${GCCPREFIX}ld${LINKER_SUFFIX}" \
+		"$LDFLAGS --no-warn-rwx-segments" && \
+		LDFLAGS="$LDFLAGS --no-warn-rwx-segments"
+
    case "$architecture" in
    x86)
    	;;