Change in coreboot[master]: [TESTME]biostar/am1ml: fix the VGA-related PCI resource allocation pr...
Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38218 )
Change subject: [TESTME]biostar/am1ml: fix the VGA-related PCI resource allocation problems ......................................................................
[TESTME]biostar/am1ml: fix the VGA-related PCI resource allocation problems
This workaround helps to avoid the PCI resource allocation problems which happen if a discrete VGA adapter (i.e. AMD HD6670) has been plugged in to AM1ML board. It does not bring any downsides if there is no discrete VGA adapter.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: Ia74750395e725a2522b7b55efb79084a073c1447 --- M src/mainboard/biostar/am1ml/OemCustomize.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/38218/1
diff --git a/src/mainboard/biostar/am1ml/OemCustomize.c b/src/mainboard/biostar/am1ml/OemCustomize.c index 2f7666e..212a538 100644 --- a/src/mainboard/biostar/am1ml/OemCustomize.c +++ b/src/mainboard/biostar/am1ml/OemCustomize.c @@ -147,6 +147,8 @@
void board_BeforeInitPost(struct sysinfo *cb, AMD_POST_PARAMS *InitPost) { + /* Set to 0xD0 instead of 0xE0 to avoid the PCI resource allocation problems. */ + InitPost->MemConfig.BottomIo = 0xD0; InitPost->MemConfig.PlatformMemoryConfiguration = (PSO_ENTRY *)PlatformMemoryTable; }
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38218 )
Change subject: [TESTME]biostar/am1ml: fix the VGA-related PCI resource allocation problems ......................................................................
Patch Set 1:
Please review, hopefully you have a spare discrete GPU to test this.
Hello Sergej Ivanov, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38218
to look at the new patch set (#2).
Change subject: [TESTME]biostar/am1ml: fix the VGA-related PCI resource allocation problems ......................................................................
[TESTME]biostar/am1ml: fix the VGA-related PCI resource allocation problems
This workaround helps to avoid the PCI resource allocation problems which happen if a discrete VGA adapter (i.e. AMD HD6670) has been plugged in to AM1ML board. It does not bring any downsides if there is no discrete VGA adapter.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: Ia74750395e725a2522b7b55efb79084a073c1447 --- M src/mainboard/biostar/am1ml/OemCustomize.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/38218/2
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38218 )
Change subject: [TESTME]biostar/am1ml: fix the VGA-related PCI resource allocation problems ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38218/2/src/mainboard/biostar/am1ml... File src/mainboard/biostar/am1ml/OemCustomize.c:
https://review.coreboot.org/c/coreboot/+/38218/2/src/mainboard/biostar/am1ml... PS2, Line 150: /* Set to 0x40 instead of 0xE0 to avoid the PCI resource allocation problems. */ : InitPost->MemConfig.BottomIo = 0x40; See CB:30987 comment here for more info about this change from 0xD0 to 0x40 - https://review.coreboot.org/c/coreboot/+/30987/45/src/mainboard/asus/a88xm-e...
Mike Banon has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/38218 )
Change subject: [TESTME]biostar/am1ml: fix the VGA-related PCI resource allocation problems ......................................................................
Abandoned
Superseded by CB:38472 (amd/agesa: Make BottomIo position configurable)
-
Mike Banon (Code Review)