Change in coreboot[master]: mb/google/trogdor: Add new configs gelarshie - coreboot-gerrit

7 Mar 2022


      Attention is currently required from: Bob Moragues, Julius Werner, Mars Chen.
Douglas Anderson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62642 )
Change subject: mb/google/trogdor: Add new configs gelarshie
......................................................................
Patch Set 1: -Code-Review
(1 comment)
File src/mainboard/google/trogdor/Kconfig:
https://review.coreboot.org/c/coreboot/+/62642/comment/6238b35e_2699fca1 
PS1, Line 10: TROGDOR_HAS_BRIDGE_BACKLIGHT
Actually, are you sure about setting this one to "Y"? I believe Homestar set this to `y` because it had an AMOLED display that did its own backlight control. Are you sure that's the right config for gelarshie?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/62642
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie83df3c753d0863841430fe62805250ef8efeae9
Gerrit-Change-Number: 62642
Gerrit-PatchSet: 1
Gerrit-Owner: Mars Chen chenxiangrui@huaqin.corp-partner.google.com
Gerrit-Reviewer: Bob Moragues moragues@google.com
Gerrit-Reviewer: Douglas Anderson dianders@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Bob Moragues moragues@google.com
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Mars Chen chenxiangrui@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Mon, 07 Mar 2022 21:10:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment