Attention is currently required from: Paul Menzel, Ronald Claveau.
Felix Singer has posted comments on this change by Ronald Claveau. ( https://review.coreboot.org/c/coreboot/+/83104?usp=email )
Change subject: mainboard/dell: Add new mainboard XPS 8300 (Sandy Bridge) ......................................................................
Patch Set 11:
(7 comments)
File src/mainboard/dell/xps_8300/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/83104/comment/c434bac3_22701280?usp... : PS11, Line 1: chip northbridge/intel/sandybridge ```suggestion # SPDX-License-Identifier: GPL-2.0-only
chip northbridge/intel/sandybridge ```
https://review.coreboot.org/c/coreboot/+/83104/comment/03dc294f_3c224179?usp... : PS11, Line 6: register "gen1_dec" = "0x003c0a01" Move this into the scope of the LPC controller
https://review.coreboot.org/c/coreboot/+/83104/comment/952677d6_78f822fb?usp... : PS11, Line 8: register "sata_interface_speed_support" = "0x3" : Move these into the scope of the SATA controller
https://review.coreboot.org/c/coreboot/+/83104/comment/b50d7a5f_add9307f?usp... : PS11, Line 30: # Management Engine Interface 1 These comments duplicate the alias names. Remove them as well.
https://review.coreboot.org/c/coreboot/+/83104/comment/9a0a2881_864b5de3?usp... : PS11, Line 33: off Remove all devices which are turned off. They are disabled in the chipset devicetree.
File src/mainboard/dell/xps_8300/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/83104/comment/5a3d5cbf_4898ab6d?usp... : PS11, Line 5: nit: Remove one blank line
File src/mainboard/dell/xps_8300/early_init.c:
https://review.coreboot.org/c/coreboot/+/83104/comment/d0a4800e_51613b94?usp... : PS11, Line 3: nit: Remove one blank line